You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Adding new API(s)
Adding a new API version
Adding a new service
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Removing API(s) in stable version
Removing properties in stable version
Removing API version(s) in stable version
Updating API in stable version with Breaking Change Validation errors
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
️✔️ Generate from 9b674d4 with merge commit c43fbcc. SDK Automation 13.0.17.20200619.4
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-02-01-preview'} in label v2018_02_01_preview
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2018-02-01-preview based on label v2018_02_01_preview
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-09-01'} in label v2018_09_01
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2018-09-01 based on label v2018_09_01
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-04-01'} in label v2019_04_01
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2019-04-01 based on label v2019_04_01
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2019-05-01'} in label v2019_05_01
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01 based on label v2019_05_01
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-05-01-preview'} in label v2019_05_01_preview
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01-preview based on label v2019_05_01_preview
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2019-06-01-preview', '2019-05-01', '2019-05-01-preview'} in label v2019_06_01_preview
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2019-06-01-preview based on label v2019_06_01_preview
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Found too much API version: {'2019-12-01-preview', '2019-06-01-preview', '2019-05-01-preview'} in label v2019_12_01_preview
[azure-mgmt-containerregistry][after_scripts|python] WARNING:__main__:Guessing you want 2019-12-01-preview based on label v2019_12_01_preview
[build_conf] INFO:packaging_tools:Building template azure-mgmt-containerregistry
[build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
[build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
[build_conf] INFO:packaging_tools:Template done azure-mgmt-containerregistry
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-02-01-preview'} in label v2018_02_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2018-02-01-preview based on label v2018_02_01_preview
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-09-01'} in label v2018_09_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-09-01 based on label v2018_09_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-04-01'} in label v2019_04_01
[after_scripts|python] WARNING:__main__:Guessing you want 2019-04-01 based on label v2019_04_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2019-05-01'} in label v2019_05_01
[after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01 based on label v2019_05_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-05-01-preview'} in label v2019_05_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01-preview based on label v2019_05_01_preview
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-06-01-preview', '2019-05-01', '2019-05-01-preview'} in label v2019_06_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2019-06-01-preview based on label v2019_06_01_preview
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-12-01-preview', '2019-06-01-preview', '2019-05-01-preview'} in label v2019_12_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2019-12-01-preview based on label v2019_12_01_preview
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package] warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package] warnings.warn(msg)
[breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
[ChangeLog] Size of delta 0.241% size of original (original: 120624 chars, delta: 291 chars)
[ChangeLog] **Features**
[ChangeLog]
[ChangeLog] - Model ExportPipeline has a new parameter location
[ChangeLog] - Model ImportPipeline has a new parameter location
@fengzhou-msft we are introducing this change because our existing create flow for exportPipeline and importPipeline is broken for SDK users due to errors from Managed Identity. These are proxy resources that are onboarded to managed identity, however they were initially released without a Location property due to ARM's API contract that proxy resources will inherit location from their parent tracked resource, which in this case is a registry. ARM routes the requests for these proxy resources to the parent location RP endpoint. See ARM wiki. However, for MI-enabled proxy resources, ARM explicitly looks for Location in the request body in order to route to the MI RP. With no Location provided, ARM cannot route the request to MI and PUT fails with IdentityServiceUnavailble. We are hoping this change can be included in the existing preview API version as the current create flow for these resources is broken. @mnltejaswini
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Approved-BreakingChangeDO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.